fix: Update backend dependency containing updated pk write fix #956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #905
Description
The context for this PR can be found in the issue and the downstream
noir-lang/aztec-connect
PR: noir-lang/aztec-connect#26. Once this is approved and merged I can merge the aztec_backend PR linked below, and then finally this PR.I also made the relevant change to upstream bb: AztecProtocol/barretenberg#204.
Backend PR: noir-lang/acvm-backend-barretenberg#78
Summary of changes
All changes can be found in the downstream PRs.
Dependency additions / changes
The aztec_backend dependency needs to be updated to reflect the changes to how we write the proving key to buffer in C++.
Test additions / changes
We are testing checking whether the Noir CI still passes as usual.
I also tested on the
poseidonsponge_x5_254
test example linked in issue #905 that this PR resolves. It is currently no longer giving a buffer serialization error onnargo prove p
, but proof verification is returning false. This looks like it may be a separate error with the impl or a bug in Noir though.Checklist
cargo fmt
with default settings.Documentation needs
Additional context