Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when right clicking on a link #5625

Closed
5 of 6 tasks
Grumvol opened this issue Apr 11, 2022 · 9 comments
Closed
5 of 6 tasks

Unexpected behavior when right clicking on a link #5625

Grumvol opened this issue Apr 11, 2022 · 9 comments
Labels

Comments

@Grumvol
Copy link

Grumvol commented Apr 11, 2022

Check that this is really a bug

  • I confirm

Reproduction link

https://swiperjs.com/demos#slides-per-view

Bug description

Right-clicking on a link in a slide will move to the next slide. To reproduce the error, the slide must not be the first in a row.

QIP Shot - Screen 1287

Expected Behavior

Context menu open

Actual Behavior

Move to the next slide and context menu open

Swiper version

8.1.0

Platform/Target and Browser Versions

Windows 10, Chrome

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@robizzt
Copy link

robizzt commented Apr 21, 2022

Can confirm, same happening to me. If the slide is not on the first position, the right click will move that slide to the first position.

@ThatWebCo
Copy link

Same happening here. Only seems to happen when slidesPerGroup is a different number to slidesPerView.

@Grumvol
Copy link
Author

Grumvol commented Jun 1, 2022

Same behavior on smartphones after touch. That is, it is impossible to follow the link if it is inside the slide. Almost 2 months have passed, but this bug has not been fixed. Am I the only one who cares about the fact that it is impossible to use links inside slides.

@mohamadsinane
Copy link

Hello, i got the same issue.
It seams that adding watchSlidesProgress: true, to my default config fixes the issue.

@Grumvol
Copy link
Author

Grumvol commented Jul 22, 2022

watchSlidesProgress: true

Thanks

@dijkermans
Copy link

dijkermans commented Aug 10, 2022

Hello, i got the same issue. It seams that adding watchSlidesProgress: true, to my default config fixes the issue.

Yes but I noticed it's CPU intensive. My sliders become laggy so I hope there's a better solution.

I'm using version 8.3.2.

@Superhands89
Copy link

This is now fixed for desktop but this is still an issue on mobile/touch devices in version 8.4.2

@Blacklightdesign
Copy link
Contributor

I have a solution that mobile touch on ui elements like links or select fields no longer makes the slide jump to first place. Touch events also trigger a focus event. I added a condition to check that the focus event was not triggered by touch.
#6139

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants