-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nice Work! #1
Comments
Hi and thanks @nolman, for the buildpack. This is the only one I could find that still works today on heroku, and now because heroku supports multiple buildpacks, your solution is probably the cleanest and easiest one.
@justin808, it's been years since you've asked your question, but for the sake of others :) I think the |
Hi @BenTalagan - glad the buildpack worked for you. Appreciate the feedback - the extra script is indeed for compiling source code on the same platform as it will be run (e.g. a heroku dyno). It has been awhile but IIRC I ended up making a fork of gsl to fix a bug in it and needed to compile the source to make my own binary. If someone opened a PR to make the readme cleaner I would happily merge it :) |
Thanks for the buildpack!
I'm guessing you included the sample script of building binaries in case one wants to create their own.
Would it make more sense, given the caching from heroku deploys, to build the binary as part of the buildpack, rather than having your pre-built one on AWS?
Also, you might want to make the README a bit more clear on how this is working. From the README, it seemed that I had to put fog in my Gemfile for my Heroku App (which maybe I do if I was to change the script to build the binaries?).
The text was updated successfully, but these errors were encountered: