Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen 3.4 support? #496

Closed
risicle opened this issue May 28, 2022 · 1 comment
Closed

Eigen 3.4 support? #496

risicle opened this issue May 28, 2022 · 1 comment

Comments

@risicle
Copy link

risicle commented May 28, 2022

In the NixOS package for libpointmatcher we noticed that building 1.3.1 fails once we upgrade to eigen 3.4.0:

/build/source/pointmatcher/DataPointsFilters/Gestalt.cpp:498:52: error: no match for 'operator+=' (operand types are 'Eigen::internal::enable_if<true, Eigen::IndexedView<Eigen::Matrix<float, -1, -1>, float, float> >::type' {aka 'Eigen::IndexedView<Eigen::Matrix<float, -1, -1>, float, float>'} and 'Eigen::DenseCoeffsBase<Eigen::Matrix<float, -1, 1>, 1>::Scalar' {aka 'float'})
  498 |         gestaltMeans(indices(0,it), indices(1,it)) += heights(it);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~

Full build log available at https://hydra.nixos.org/log/62jmdhygsddz94mdandsg0cni94gv17r-libpointmatcher-1.3.1.drv

It seems that indexed and sliced views had a bit of an overhaul in 3.4 (https://eigen.tuxfamily.org/index.php?title=3.4#New_Major_Features_in_Core) - is it possible this usage wasn't intended to be supported?

@boxanm
Copy link
Collaborator

boxanm commented Nov 17, 2023

The current develop branch compiles with Eigen 3.4; we will draft a release soon with these changes. Stay tuned!

@boxanm boxanm closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants