Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate fluent types and preference key types #62

Open
2 tasks
northword opened this issue Dec 7, 2024 · 2 comments · May be fixed by #86
Open
2 tasks

Generate fluent types and preference key types #62

northword opened this issue Dec 7, 2024 · 2 comments · May be fixed by #86
Labels
enhancement New feature or request

Comments

@northword
Copy link
Owner

northword commented Dec 7, 2024 •
edited
Loading

fluent types: https://github.com/dvanoni/notero/blob/main/scripts/generate-fluent-types.ts

preference key types: #54

需要对 zotero-types 做一些修改 (可能)：

  • decalre const Zotero {} -> declare namespace Zotero {}，因为 const 不支持继承/扩展

  • Zotero.Prefs.get(key: string | boolean | number) ->

    type PrefKey = string | boolean | number
Zotero.Prefs.get(key: PrefKey)
@northword northword added the enhancement New feature or request label Dec 7, 2024
@northword northword linked a pull request Jan 5, 2025 that will close this issue
Draft
@northword
Copy link
Owner Author

northword commented Jan 5, 2025 •
edited
Loading

dts for fluent message:

Pending, wait for zotero-types add I10n.Localization types.

https://github.com/dvanoni/notero/blob/3dc67035f58e4dcaa693875a0f24603d065238fd/types/l10n.d.ts#L54

@northword
Copy link
Owner Author

Just for note:

Prettier not support ignore file by comment, comment only ignore next line:

may need to (one of):

  • modify .prettierignore
  • add // prettier for each code block
  • run and prettier or lint for this dts file after it generated
  • modify .gitignore to ignore this file from vcs

ref: windingwind/zotero-plugin-template#236

northword added a commit that referenced this issue Jan 6, 2025
@northword
fix: add prettier-ignore to prefs dts
fe23b03 
ref: #62 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generate fluent message types northword/zotero-plugin-scaffold
1 participant
@northword