Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the skip flag for radios does not update others states #423

Open
Panman82 opened this issue Jan 22, 2015 · 1 comment
Open

Using the skip flag for radios does not update others states #423

Panman82 opened this issue Jan 22, 2015 · 1 comment
Assignees
Labels

Comments

@Panman82
Copy link

There is a bug where if the skip flag is used when bootstrap-switch's are radios, the other radio states are not updated. I've created a jsFiddle showing this issue. Click the second or third switch, then use the buttons. http://jsfiddle.net/xyLrbjka/

Looking at the code, updating the radio's only happens if 'skip' is false. https://github.com/nostalgiaz/bootstrap-switch/blob/v3.3.1/src/coffee/bootstrap-switch.coffee#L366

So, the 'skip' flag is use for more than muting the switchChange event. Seems like there should be a fourth argument used internally for radios. That way the two function separately.

@frapontillo
Copy link
Contributor

@LostCrew are there updates on this? Could we introduce some other kind of event that is always triggered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants