Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor server auth #1021

Open
endophage opened this issue Oct 31, 2016 · 3 comments
Open

Refactor server auth #1021

endophage opened this issue Oct 31, 2016 · 3 comments

Comments

@endophage
Copy link
Contributor

I've had to implement some slightly messy functionality to handle auth for the changefeed. We should to take another look at how we've implemented auth and come up with a cleaner implementation.

@ecordell
Copy link
Contributor

ecordell commented Jan 19, 2017

What about plugins from go1.8? I had to do some not-really-upstreamable wrapping to get auth working with our implementation of registry auth. Would've been nice to be able to load it into vanilla notary without wrapping it.

@endophage
Copy link
Contributor Author

I think there's two components here. This issue was to address the organizational aspect of the code and where/how authz is applied. I think we'd want to address that either way.

Happy for there to be an additional issue to discuss the best way of adding alternative authz methods, and I'm tentatively excited about Go 1.8 plugins so IMO it should definitely be in consideration.

@endophage
Copy link
Contributor Author

endophage commented Jan 23, 2017

p.s. the big problem I was having with the changefeed was basically the location in the call graph that we invoke the authz checks, and how we bypass or allow an alternate authz mechanism for some endpoints vs others. The use case for that is imagine we had a way to point a downstream notary mirror at the upstream changefeed with say, mtls based authz, while still requiring token authz on the normal TUF endpoints.

@endophage endophage added this to the 0.6.0 milestone Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants