Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using cached metadata should not be a silent error #1162

Closed
ecordell opened this issue May 16, 2017 · 1 comment
Closed

Using cached metadata should not be a silent error #1162

ecordell opened this issue May 16, 2017 · 1 comment

Comments

@ecordell
Copy link
Contributor

The notary client being unable to update and re-using cached local metadata instead should not be a silent warning that's only visible with debug logging:

WARN[0002] Error while downloading remote metadata, using cached timestamp - this might not be the latest version available remotely

Depending on what you're doing it may be okay to use the cached metadata, but it probably shouldn't be silent.

@riyazdf
Copy link
Contributor

riyazdf commented May 16, 2017

Agreed - I think the default logging level is fatal.

Generally I'm of the opinion that maybe we should lower notary's default log level to warning or error and adjust the verbose/debug flags appropriately? It could also be a print, which would be a simpler fix though there could be other cases like this one that we want to bubble up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants