From 5273bbbd0e9b729b12b6cc3c242427be178bca22 Mon Sep 17 00:00:00 2001 From: Shana Moore Date: Wed, 22 Nov 2023 13:00:34 -0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=84=20rubocop=20fixes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../flipflop/strategies_controller_decorator.rb | 2 +- .../hyrax/admin/strategies_controller_decorator.rb | 2 +- app/helpers/pdf_js_helper.rb | 8 ++++---- app/presenters/hyku/work_show_presenter.rb | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/controllers/flipflop/strategies_controller_decorator.rb b/app/controllers/flipflop/strategies_controller_decorator.rb index cb7e0ee2..79f66a72 100644 --- a/app/controllers/flipflop/strategies_controller_decorator.rb +++ b/app/controllers/flipflop/strategies_controller_decorator.rb @@ -8,7 +8,7 @@ def enable? values = StrategiesController::ENABLE_VALUES | ADDITIONAL_ENABLE_VALUES values.include?(params[:commit]) end - + def features_url(**_kargs) hyrax.admin_features_path end diff --git a/app/controllers/hyrax/admin/strategies_controller_decorator.rb b/app/controllers/hyrax/admin/strategies_controller_decorator.rb index aa2b2a32..091012e3 100644 --- a/app/controllers/hyrax/admin/strategies_controller_decorator.rb +++ b/app/controllers/hyrax/admin/strategies_controller_decorator.rb @@ -12,4 +12,4 @@ def features_url(**_kargs) end end -Hyrax::Admin::StrategiesController.prepend(Hyrax::Admin::StrategiesControllerDecorator) \ No newline at end of file +Hyrax::Admin::StrategiesController.prepend(Hyrax::Admin::StrategiesControllerDecorator) diff --git a/app/helpers/pdf_js_helper.rb b/app/helpers/pdf_js_helper.rb index a21c8e01..653ee81d 100644 --- a/app/helpers/pdf_js_helper.rb +++ b/app/helpers/pdf_js_helper.rb @@ -3,7 +3,7 @@ module PdfJsHelper def pdf_js_url(file_set_presenter) # assumes that the download path exists if the file set has been characterized - path = if file_set_presenter.mime_type + path = if file_set_presenter.mime_type hyrax.download_path(file_set_presenter.id) else file_set_presenter.solr_document["import_url_ssim"].first @@ -14,16 +14,16 @@ def pdf_js_url(file_set_presenter) def pdf_file_set_presenter(presenter) # currently only supports one pdf per work, falls back to the first pdf file set in ordered members - + # Commenting this line out because even PDFs that were not split will still have a representative media # which will be used first in this logic, consider uncommenting once all imports finish - # representative_presenter(presenter) || + # representative_presenter(presenter) || first_file_set_pdf(presenter) end def first_file_set_pdf(presenter) pdf_file_set_presenters = presenter.file_set_presenters.select(&:pdf?) - reader, archival = pdf_file_set_presenters.partition do |fsp| + reader, archival = pdf_file_set_presenters.partition do |fsp| fsp.solr_document["import_url_ssim"]&.first&.include? "READER" end diff --git a/app/presenters/hyku/work_show_presenter.rb b/app/presenters/hyku/work_show_presenter.rb index 2c2c12ae..5b631f9a 100644 --- a/app/presenters/hyku/work_show_presenter.rb +++ b/app/presenters/hyku/work_show_presenter.rb @@ -32,7 +32,7 @@ def video_embed_viewer def pdf_viewer? return unless Flipflop.default_pdf_viewer? return unless file_set_presenters.any?(&:pdf?) - + # If all of the member_presenters are file_set presenters, return true # this also means that there are no child works member_presenters.all? { |presenter| presenter.is_a? Hyrax::FileSetPresenter }