-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UV not rendering after split #178
Comments
Local: This may be the issue - I created a Generic Work and attached a multi page pdf. The pdfs are attached but the UV displays an error. Yarn did not fix it. I think Hyku/adventist_dev is missing the pdfjs directory in its public folder. |
This is required to render PDF.js TODO - update adventist_knapsack after this gets merged into adventist_dev Issue: - https://github.com/scientist-softserv/adventist-dl/issues/748
PR started: TODO:Update Adventist Knapsack submodule once it gets merged into HYKU/adventist_dev |
We needed to move everything into a web subdirectory of PDF.js for the app to find files. Related Issues: - https://github.com/scientist-softserv/adventist-dl/issues/748 - https://github.com/scientist-softserv/adventist-dl/issues/746
Team, I'm having a heck of a time trying to test this ticket. I can't get a new work into either ADL or SDAPI production tenants, because of bugs that are blocking single upload and bulkrax imports. So I can't see if a new work will split and render in the UV as expected. I can confirm that uploads from about a week ago or earlier this week are either a) not showing in the UV or any viewer, despite splitting, or b) not splitting at all and just stopped at the PDF.js stage. On a staging site, I managed to use Bulkrax to bring in a work via OAI, and it has not split yet (see link below). It's been a couple hours since import. No splitting, no UV...so I still can't test. I feel pretty stuck. It seems like this ticket isn't fixed, based on older works, but I can't confirm with a new upload until other blockers are cleared...unless you have a suggestion for me. I imported the above work using this importer, which brought in a second work which HAS split, but incorrectly. There are issues with the child works and how they render in the viewer. The UV is rendering, but: |
Related to this ticket, I found a work that has child works visible via the Dashboard, but they don't show on the parent record in the items list. The work is not loading in the UV, the child works seem lost, and even PDF.js isn't rendering right now (it's been spinning for a few minutes). https://adl.b2.adventistdigitallibrary.org/concern/published_works/22266530_cardinal_2017 No child works on the work page: Child works do show on the Dashboard: Here's one of them: https://adl.b2.adventistdigitallibrary.org/concern/published_works/6c63102e-2e93-40bc-84df-e7fcd46ee127?locale=en |
Hi @KatharineV Is this still an issue? ref: https://adl.b2.adventistdigitallibrary.org/concern/published_works/22266530_cardinal_2017 This morning I've been testing with https://april-test.b2.adventistdigitallibrary.org/concern/images/b1e2291b-edfa-421e-87ff-7d49d28ec3f5?locale=en and here are my results. (this is a manually created work with files attached. UV feature turned on. jobs complete) |
Confirmed that the work that was stuck before is rendering in the UV now. https://adl.b2.adventistdigitallibrary.org/concern/published_works/22266530_cardinal_2017 Hooray! I also just uploaded a set of works to SDAPI prod using a CSV/files importer and the PDFs split and are displaying as expected in the UV: |
Team, I found a work today where the UV isn't rendering anything on ADL prod: https://adl.b2.adventistdigitallibrary.org/concern/images/20000208_illustration_of_harmon_hall. The attached files are images, so I expect to see the UV, not PDF.js. I see nothing. Is this a one-off issue or possibly related to the UV bug, post-Knapsack? Thanks for checking! Here's how the work is displaying for me right now: |
Got it. We'll take a look. |
@KatharineV Do you know how this record was created? The first tiff file isn't actually present or downloadable. Can we delete that file and/or try recreating this record? |
Yes, this is a work that my predecessor uploaded using Bulkrax and the OAI feed (adl:image set, I believe) back in December 2021. It would be part of the earliest batch uploads. Other works from those loads do show in the UV, which is why I'm suspicious this might be an issue with the work, not Knapsack. I see your edits now. Let me try updating that single record and TIFF! |
Works uploaded after Knapsack are not rendering in the UV after the pages are split. We expect all split documents to render in the UV.
In this screenshot from SDAPI prod, you see the first split page shows in the Items list, but the document doesn't render in PDF.js (see #180) or the UV.
https://sdapi.b2.adventistdigitallibrary.org/concern/journal_articles/dialogue_2023_2_29_31_a_pioneer_of_adventist_church_school_curriculum_alma
![Image](https://private-user-images.githubusercontent.com/118196520/322007346-c28da5d3-6f83-4352-8087-c6424e276d03.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjcyMzksIm5iZiI6MTczODkyNjkzOSwicGF0aCI6Ii8xMTgxOTY1MjAvMzIyMDA3MzQ2LWMyOGRhNWQzLTZmODMtNDM1Mi04MDg3LWM2NDI0ZTI3NmQwMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QxMTE1MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zZWI5ZjEzNDY0ZTE3MzlmZWRlNjlmOWUwZWYyZmMyN2Q2NGUyNTViZjQ5MTZkZTdlYmU0NDA0NDJiZmMyYjZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.g-llYRjyHnvoamH2_TVXQwTSvQslJDirwtsXzXJHwcA)
The text was updated successfully, but these errors were encountered: