Blacklight 7 SearchHelper Removal

[ShanaLMoore]

Upgrading blacklight to 7 removed the SearchHelper module, that GBH is using in their AMS::Export::CatalogSearch file.

We decided to time box our efforts to resolve issues to be as close as possible to .dassie/hyrax. If it proves to be too difficult we would make tickets that someone could address separately, while others continue on with the upgrade.

In this case we are noting that we need to figure out what needs to change due to the removal of Blacklight::SearchHelper.

PS. There is a spec for this that may help.

reference WIP turned into this ticket:
search_helper_catalog.rb

search_helper_catalog_spec.rb => currently skips running this test if future rails

run specs with DEPENDENCIES_NEXT=1 prepended to your commands

notes

dassie is a good reference point because they had to upgrade it from 2.9.6 yo hyrax 4 so there should be a lot of clues to follow.

Maybe helpful resources for us in this process:
Upgrade to Blacklight 7, Bootstrap 4 and Rails 6.0
Update koppie catalog controller for blacklight 7
blacklight Version 7.0.0 release notes

run spec like DEPENDENCIES_NEXT=1 rspec ./spec/services/ams/export/search/digital_instantiations_search_spec.rb:44

[ShanaLMoore]

Look for TODO comments in main regarding catalog_search files and specs.

[ShanaLMoore]

We replaced Blacklight::SearchHelper with a call to Hyrax::SearchService.