Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute back to HykuKnapsack #232

Closed
12 of 13 tasks
Tracked by #225
kirkkwang opened this issue Jun 11, 2024 · 1 comment
Closed
12 of 13 tasks
Tracked by #225

Contribute back to HykuKnapsack #232

kirkkwang opened this issue Jun 11, 2024 · 1 comment
Assignees

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Jun 11, 2024

Story

With the development of Pals Knapsack, we've done a lot of things that should be contributed back to HykuKnapsack.

Acceptance Criteria

  • update the generator
    • include the video validation line
    • change the parent class the form inherits from
    • not generate the controllers for "SomethingResource"
    • indexers need to also include HykuIndexing
    • change the parent class the indexer inherits from
    • adjust indexer spec
  • update the HykuKnapsack::Engine
  • update the rails_helper.rb
  • wrap hyrax initializer in an after_initialize
  • add symlink in Dockerfile for branding (this should be in Hyku)
  • update Hyku submodule
  • update Gemfile.lock

Screenshots / Video

Testing Instructions and Sample Files

Notes

@ShanaLMoore ShanaLMoore added the blocked other work must be completed first label Jul 9, 2024
@ShanaLMoore
Copy link

blocked by hyku v6.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants