Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention not working as intended for expected sorting #167

Closed
3 tasks
kirkkwang opened this issue Mar 8, 2023 · 7 comments
Closed
3 tasks

Naming convention not working as intended for expected sorting #167

kirkkwang opened this issue Mar 8, 2023 · 7 comments
Assignees
Labels
bug Something isn't working IiifPrint

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Mar 8, 2023

Summary

Title sorting behaves undesirably after nine items.

Ex:

titles = ["Foo Pdf Nbr 1, Page 1",
          "Foo Pdf Nbr 1, Page 2",
          "Foo Pdf Nbr 1, Page 3",
          "Foo Pdf Nbr 1, Page 4",
          "Foo Pdf Nbr 1, Page 5",
          "Foo Pdf Nbr 1, Page 6",
          "Foo Pdf Nbr 1, Page 7",
          "Foo Pdf Nbr 1, Page 8",
          "Foo Pdf Nbr 1, Page 9",
          "Foo Pdf Nbr 1, Page 10"]
titles.sort 
#=> ["Foo Pdf Nbr 1, Page 1",
#    "Foo Pdf Nbr 1, Page 10", # undesirable order
#    "Foo Pdf Nbr 1, Page 2",
#    "Foo Pdf Nbr 1, Page 3",
#    "Foo Pdf Nbr 1, Page 4",
#    "Foo Pdf Nbr 1, Page 5",
#    "Foo Pdf Nbr 1, Page 6",
#    "Foo Pdf Nbr 1, Page 7",
#    "Foo Pdf Nbr 1, Page 8",
#    "Foo Pdf Nbr 1, Page 9"]

Acceptance Criteria

  • Titles should sort in an expected manner where 10 does not come after 1

Screenshots or Video

Testing Instructions

  • Ingest this Sample PDF
  • observe that the titles go in a predictable order

Notes

Padding the numbers with zeros can be a solution.

@kirkkwang kirkkwang changed the title Naming not working as intended for expected sorting Naming convention not working as intended for expected sorting Mar 8, 2023
@kirkkwang kirkkwang added bug Something isn't working IiifPrint labels Mar 8, 2023
@kirkkwang kirkkwang moved this to In Development in IIIF_Print Mar 9, 2023
@ShanaLMoore ShanaLMoore moved this from In Development to Code Review in IIIF_Print Mar 9, 2023
@laritakr laritakr moved this from Code Review to Deploy to Staging in IIIF_Print Mar 10, 2023
@ShanaLMoore
Copy link
Contributor

blocked until client gives us a staging to deploy to

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Mar 27, 2023

@kirkkwang can QA be done on another app? please update the testing instructions if so, I'm going to see what DIem's availability is today.

@kirkkwang
Copy link
Contributor Author

Yes, I'll have to check which app has the revision with this feature

@DiemBTran DiemBTran moved this from Deploy to Staging to Ready for Development in IIIF_Print Mar 28, 2023
@DiemBTran
Copy link

Needs further review: It looks like a 20-page document has been running its derivatives for 3 hours. This may be unusual behavior.

tested on:

20-page PDF still has its derivatives being run. Its children works are being made, but they have not been attached to the parent.

Article naming convention ID 531123c9-daa2-4c1f-a0d1-dd7502899d31 Hyku 2023-03-27 at 5 17 38 PM
Sidekiq 2023-03-27 at 5 18 05 PM
Works 2023-03-27 at 5 20 34 PM

Works 2023-03-27 at 5 20 57 PM

@laritakr
Copy link
Contributor

As of this morning, this completed normally. Staging for BL is extremely backed up, and the create relationship job has to run before the works are connected to the parent.

@laritakr laritakr moved this from Ready for Development to SoftServ QA in IIIF_Print Mar 28, 2023
@DiemBTran
Copy link

This passes SoftServ QA: The 20-page document successfully finished creating its derivatives overnight. This took so long only because staging is backed up.

tested on:

20-page PDF has its pages in order.

Article naming convention ID 531123c9-daa2-4c1f-a0d1-dd7502899d31 Hyku 2023-03-28 at 11 37 40 AM

@DiemBTran
Copy link

closing as this was a internal issue

@github-project-automation github-project-automation bot moved this from SoftServ QA to Done in IIIF_Print Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IiifPrint
Projects
Status: Done
Development

No branches or pull requests

5 participants