Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCR Catalog Search #88

Closed
1 task done
ShanaLMoore opened this issue Jan 26, 2023 · 4 comments
Closed
1 task done

Fix OCR Catalog Search #88

ShanaLMoore opened this issue Jan 26, 2023 · 4 comments
Assignees

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 26, 2023

Summary

Is full or all text getting indexed? etc...

Acceptance Criteria

Screenshots or Video

Testing Instructions

Deploy i87-ocr-search to hyku-iiif (hyku branch) ✅ visit: demo.hyku-iiif.notch8.cloud/

  1. Create a work. Upload an image that has text. OCR should run. Confirm that json coordinates are created as its derivatives. Confirm that a user can search for the text in the UV, and find a match.
  2. Create a work. Attach a child. Confirm that a user can visit the parent's UV, search for the child's metadata and find a match.
  3. A user should able be able to catalog search the child metadata and have its parent return
  4. A user should be able to catalog search the child's ocr term and have its parent return

Notes

The commits in Louisville that worked towards this are:

maybe helpful refs:

  1. https://gitlab.com/notch8/louisville-hyku/-/merge_requests?scope=all&state=merged&search=ocr

If things aren't working, try...

ActiveFedora::Base.reindex_everything

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jan 26, 2023

to get this working, we needed to add and set advanced_parse to false, in the catalog controller.

For now we will note this in the readme, and decide if and how iiifprint should generate this in the future.

Image

@jillpe jillpe changed the title Fix OCR Catalog Search Spike: Fix OCR Catalog Search Feb 6, 2023
@ShanaLMoore ShanaLMoore moved this from Ready for Development to SoftServ QA in IIIF_Print Feb 6, 2023
@laritakr
Copy link
Contributor

laritakr commented Feb 7, 2023

@ShanaLMoore I don't see that the referenced branch is ready to deploy or has been deployed. Should this be moved back to "deploy to staging"?

@ShanaLMoore
Copy link
Contributor Author

Yes, the deploy failed. I will move this back to deploy to staging.

@ShanaLMoore ShanaLMoore moved this from SoftServ QA to Deploy to Staging in IIIF_Print Feb 10, 2023
@ShanaLMoore ShanaLMoore changed the title Spike: Fix OCR Catalog Search Fix OCR Catalog Search Feb 15, 2023
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to SoftServ QA in IIIF_Print Feb 15, 2023
@DeonFranklin
Copy link
Contributor

This ticket passes Soft Serv QA

Image
Image
Image
Image

@DeonFranklin DeonFranklin moved this from SoftServ QA to Client QA in IIIF_Print Feb 15, 2023
@github-project-automation github-project-automation bot moved this from Client QA to Done in IIIF_Print Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants