Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full text search for wares #172

Open
1 task
summer-cook opened this issue Feb 1, 2023 · 2 comments
Open
1 task

full text search for wares #172

summer-cook opened this issue Feb 1, 2023 · 2 comments

Comments

@summer-cook
Copy link
Contributor

summer-cook commented Feb 1, 2023

story

in the webstore search, only words that are in the ware's title are being matched. the description (snippet property in the endpoint /providers/{PROVIDER_ID}/wares ) is being ignored by the search

acceptance criteria

  • wares can be searched by their description (aka snippet)

notes

@summer-cook summer-cook converted this from a draft issue Feb 1, 2023
@summer-cook summer-cook moved this to In Development in webstore Feb 15, 2023
@summer-cook
Copy link
Contributor Author

summer-cook commented Feb 15, 2023

this seems to be working better on staging - i now get results for some things that are only in the snippets

ex. search - DNA

Image

but, it only works for some words. for instance a search for methylation returned no results, even though a ware with the word methylation in the snippet exists:

no results
Image

ware that should show up
Image

looking at the now-closed api ticket, i see that there are 2 other related tickets that have not been closed,

Full Text Search for ProviderWares #223 & WareRef Serializer should include "description" #222

so perhaps those 2 need to be pushed before this works as expected in full

@summer-cook
Copy link
Contributor Author

summer-cook commented Feb 15, 2023

More investigation:

https://github.com/assaydepot/scientist_api_v2/issues/223 will need to be merged into staging to test this completely because it will add full text search for the endpoint providers/:provider_id/wares which is what we are using in the webstore.

@summer-cook summer-cook removed the status in webstore Feb 16, 2023
@summer-cook summer-cook moved this to In Development in webstore Feb 16, 2023
@summer-cook summer-cook removed the status in webstore Feb 16, 2023
@alishaevn alishaevn removed this from webstore Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants