Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for api changes #337

Closed
1 of 5 tasks
alishaevn opened this issue Dec 14, 2023 · 0 comments · Fixed by #338
Closed
1 of 5 tasks

account for api changes #337

alishaevn opened this issue Dec 14, 2023 · 0 comments · Fixed by #338
Assignees

Comments

@alishaevn
Copy link
Member

alishaevn commented Dec 14, 2023

Summary

update all instances of proposal_ref and quoted_ware throughout the app

Acceptance Criteria

  • all instances of proposal_ref have been updated to proposal_refs
  • all instances of quoted_ware have been updated to quoted_wares
  • full functionality has been tested and confirmed that it's still operational
  • this change has been pulled into all client apps

Story

From mumen yesterday:

I’ve made some recent changes to the PO serializer on the API that might affect some of the work you’re doing. I can’t fully identify the app using the API endpoint but I do see events being made to the API by Alisha/Adelle/Andrew. The mapping changes I’ve made can be seen here: https://github.com/assaydepot/scientist_api_v2/pull/305/files#diff-def1c18bae072f37cb9dbaac42ba8234752e455f5b3bb719029386f323071c84

You will see a plural form of some of the mappings. For example, I’ve added proposal_refs which can map to multiple of proposals. I’ve left the singular mapping proposal_ref as-is so things don’t break but the idea is that a PO can now have multiple proosals. The same applies to quoted_wares. So in whatever app you’ve developed that accessed the endpoint, we’d need to update it to read the plural mapping.

it's a non breaking change since I did not change the existing mappings, I just added the plural form of the mappings so we can transition over without blowing up anything

@alishaevn alishaevn self-assigned this Dec 14, 2023
alishaevn added a commit that referenced this issue Dec 15, 2023
changes were recently made to the purchase orders serializer. this commit
updates our code so the app continues working with that change.

ref: #337
@alishaevn alishaevn linked a pull request Dec 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant