-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
339 eslint production build #340
Changes from all commits
b257bc6
5bf1c93
044883f
ba549f9
70119c2
af84514
90ede7c
bef639a
aed75d9
c71f9d7
6977eeb
cd858c3
d0d5020
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: 'Build Test Lint' | ||
run-name: Build Test Lint of ${{ github.ref_name }} by @${{ github.actor }} | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- main | ||
workflow_dispatch: | ||
inputs: | ||
debug_enabled: | ||
type: boolean | ||
description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)' | ||
required: false | ||
default: false | ||
|
||
jobs: | ||
build: | ||
uses: scientist-softserv/actions/.github/workflows/[email protected] | ||
secrets: inherit | ||
with: | ||
platforms: 'linux/amd64' | ||
webTarget: web | ||
cypress: | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Cypress e2e | ||
uses: cypress-io/github-action@v6 | ||
with: | ||
start: yarn start | ||
wait-on: 'http://localhost:3000' | ||
Comment on lines
+25
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
eslint: | ||
needs: build | ||
uses: scientist-softserv/actions/.github/workflows/[email protected] | ||
with: | ||
lint_cmd: docker compose run web sh -c 'yarn && yarn lint' | ||
Comment on lines
+35
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to edit the |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,28 +2,29 @@ | |
# In order to deploy via github actions instead, please update/confirm the following files: | ||
# - ops/production-deploy.tmpl.yaml | ||
# - ops/staging-deploy.tmpl.yaml | ||
# Next, uncomment the following lines | ||
|
||
# name: "Deploy" | ||
# run-name: Deploy (${{ github.ref_name }} -> ${{ inputs.environment }}) by @${{ github.actor }} | ||
# on: | ||
# workflow_dispatch: | ||
# inputs: | ||
# environment: | ||
# description: 'Deploy to Environment' | ||
# required: true | ||
# default: 'staging' | ||
# type: choice | ||
# options: | ||
# - staging | ||
# - production | ||
# debug_enabled: | ||
# type: boolean | ||
# description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)' | ||
# required: false | ||
# default: false | ||
name: "Deploy" | ||
run-name: Deploy (${{ github.ref_name }} -> ${{ inputs.environment }}) by @${{ github.actor }} | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
environment: | ||
description: 'Deploy to Environment' | ||
required: true | ||
default: 'staging' | ||
type: choice | ||
options: | ||
- staging | ||
- production | ||
debug_enabled: | ||
type: boolean | ||
description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)' | ||
required: false | ||
default: false | ||
|
||
# jobs: | ||
# deploy: | ||
# uses: scientist-softserv/actions/.github/workflows/[email protected] | ||
# secrets: inherit | ||
jobs: | ||
deploy: | ||
# remove the line below to enable the job | ||
if: false | ||
Comment on lines
+27
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. using this conditional to skip the workflow instead of commenting out the file. |
||
uses: scientist-softserv/actions/.github/workflows/[email protected] | ||
secrets: inherit |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,8 @@ node_modules/ | |
|
||
# Emacs | ||
*.~undo-tree~ | ||
|
||
# Cypress | ||
cypress/results | ||
cypress/screenshots | ||
cypress/videos |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,57 @@ | ||
// This guard clause allows the app to still build in the event another exception handler will be used, | ||
// or the sentry project hasn't been set up yet | ||
if (!process.env.SENTRY_DSN) return | ||
|
||
// This file sets a custom webpack configuration to use your Next.js app | ||
// with Sentry. | ||
// https://nextjs.org/docs/api-reference/next.config.js/introduction | ||
// https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/ | ||
const { withSentryConfig } = require('@sentry/nextjs') | ||
const SENTRY_DSN = process.env.SENTRY_DSN | ||
|
||
const nextConfig = { | ||
let nextConfig = { | ||
output: 'standalone', | ||
reactStrictMode: true, | ||
swcMinify: true, | ||
eslint: { | ||
dirs: ['pages', 'utils'], // Only run ESLint on the 'pages' and 'utils' directories during production builds | ||
}, | ||
sentry: { | ||
// Use `hidden-source-map` rather than `source-map` as the Webpack `devtool` | ||
// for client-side builds. (This will be the default starting in | ||
// `@sentry/nextjs` version 8.0.0.) See | ||
// https://webpack.js.org/configuration/devtool/ and | ||
// https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/#use-hidden-source-map | ||
// for more information. | ||
hideSourceMaps: true, | ||
// Warning: This allows production builds to successfully complete even if | ||
// your project has ESLint errors. | ||
// ref: https://nextjs.org/docs/pages/api-reference/next-config-js/eslint | ||
ignoreDuringBuilds: true, | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
const sentryWebpackPluginOptions = { | ||
// Additional config options for the Sentry Webpack plugin. Keep in mind that | ||
// the following options are set automatically, and overriding them is not | ||
// recommended: | ||
// release, url, configFile, stripPrefix, urlPrefix, include, ignore | ||
|
||
silent: true, // Suppresses all logs | ||
project: process.env.SENTRY_PROJECT, | ||
org: process.env.SENTRY_ORG, | ||
authToken: process.env.SENTRY_AUTH_TOKEN, | ||
// For all available options, see: | ||
// https://github.com/getsentry/sentry-webpack-plugin#options. | ||
} | ||
module.exports = nextConfig | ||
|
||
// Make sure adding Sentry options is the last code to run before exporting, to | ||
// ensure that your source maps include changes from all other Webpack plugins | ||
module.exports = withSentryConfig( | ||
nextConfig, | ||
sentryWebpackPluginOptions | ||
) | ||
let sentryWebpackPluginOptions = {} | ||
if (SENTRY_DSN) { | ||
nextConfig = { | ||
...nextConfig, | ||
sentry: { | ||
// Use `hidden-source-map` rather than `source-map` as the Webpack `devtool` | ||
// for client-side builds. (This will be the default starting in | ||
// `@sentry/nextjs` version 8.0.0.) See | ||
// https://webpack.js.org/configuration/devtool/ and | ||
// https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/#use-hidden-source-map | ||
// for more information. | ||
hideSourceMaps: true, | ||
}, | ||
} | ||
|
||
sentryWebpackPluginOptions = { | ||
// Additional config options for the Sentry Webpack plugin. Keep in mind that | ||
// the following options are set automatically, and overriding them is not | ||
// recommended: | ||
// release, url, configFile, stripPrefix, urlPrefix, include, ignore | ||
|
||
silent: true, // Suppresses all logs | ||
project: process.env.SENTRY_PROJECT, | ||
org: process.env.SENTRY_ORG, | ||
authToken: process.env.SENTRY_AUTH_TOKEN, | ||
// For all available options, see: | ||
// https://github.com/getsentry/sentry-webpack-plugin#options | ||
} | ||
|
||
module.exports = withSentryConfig( | ||
nextConfig, | ||
sentryWebpackPluginOptions | ||
) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,8 @@ export const enableCookies = () => { | |
|
||
const nonEssentialCookies = [ | ||
// TODO(alishaevn): create this list | ||
// TODO(alishaevn): add these cookies to pages/legal-notices/cookie-policy.js under "Non-essential cookies" with a description and expiration time frame | ||
// TODO(alishaevn): add these cookies to pages/legal-notices/cookie-policy.js under | ||
// "Non-essential cookies" with a description and expiration time frame | ||
Comment on lines
+38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. split into 2 lines to appease lint rules |
||
] | ||
|
||
export const disableCookies = () => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this already existed in "build.yml". I just moved it here.