Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial popover height max: The hovered window does not reach the bottom of the view #282

Open
merlinuwe opened this issue Jul 26, 2024 · 5 comments

Comments

@merlinuwe
Copy link

Thanks for your great plugin.

Is there a max for the initial popover height setting?

The higher value I give, the more the windows starts at the top, that's what I expect. At 1200 px. the window starts at the top. But the bottom of the hovered windows does not reach to the bottom.

Settings

image


400px

image


800px

image


1200px

image

  • The window doesn't get higher with changing to 1200px.

Could you please enhance this maximal possible value?

@pjeby
Copy link
Collaborator

pjeby commented Jul 26, 2024

Huh. Well, I'm gonna have to ping @nothingislost on this one, because it's something in InteractJS doing it. Initially it sets the height as requested, but then an InteractJS "move" event occurs, and then it resizes. I'm pretty sure the purpose of the resizing is to keep it within the screen boundaries, but the calculation is coming up with 703.3333px for some reason (at least on my machine) instead of the actual screen height. I don't know where it's getting that from, it seems to be calculated somewhere deep inside InteractJS.

@pjeby
Copy link
Collaborator

pjeby commented Jul 27, 2024

Huh. I found a bit of the code that restricts the maximum size to 2/3rds of the window size (height and width). Not sure what that's about. As a workaround, you can edit your main.js and change the offsetHeight/1.5 and offsetWidth/1.5 to remove the /1.5 part, which will make the maximum the size of the window rather than 2/3rds of the window.

@merlinuwe
Copy link
Author

Thank you very much for this tip, it works:

image

@yarub123
Copy link

@merlinuwe unrelated but what theme is this?

@merlinuwe
Copy link
Author

Magic user theme with "moon" selected.

https://github.com/drbap/magicuser-theme-for-obsidian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants