Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: prevent setup:project script to modify pnpm-lock file #4784

Closed
2 tasks done
michaldziuba03 opened this issue Nov 7, 2023 · 0 comments
Closed
2 tasks done
Labels

Comments

@michaldziuba03
Copy link
Contributor

📜 Description

setup:project script run pnpm install and it modifies pnpm-lock file. Commited pnpm-lock file causes unnecesary additional git conflicts.

...
"setup:project": "npx --yes [email protected] i && node scripts/setup-env-files.js && pnpm build",
...

👟 Reproduction steps

  1. git clone
  2. run npm run setup:project script from root package.json file.

👍 Expected behavior

I would suggest to run pnpm install --frozen-lock inside setup:project

👎 Actual Behavior with Screenshots

It just modifies pnpm-lock and contributors have to revert changes in pnpm-lock or remove pnpm-lock from staged files.

Commited pnpm-lock leads to unnecessary git conflicts.

Novu version

any

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant