Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: IPopoverNotificationCenterProps missing header arguments #7491

Closed
2 tasks done
david-morris opened this issue Jan 13, 2025 · 2 comments
Closed
2 tasks done
Labels

Comments

@david-morris
Copy link
Contributor

📜 Description

The types for the PopoverNotificationCenter component imply that it's not possible to let the header contain the button to edit the notification settings in the popover component. This is not true; I can use // @ts-expect-error as a workaround.

👟 Reproduction steps

  1. Use typescript
  2. use PopoverNotificationCenter
  3. supply a header render prop that contains a button to open notification settings

👍 Expected behavior

The header types should match INotificationCenterProps

👎 Actual Behavior with Screenshots

image
The header types

Novu version

Novu SaaS

npm version

NA

node version

NA

📃 Provide any additional context for the Bug.

I also filed #3285 and am still using this render prop.
I'm updating from the client version 0.3 to 2.0.

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

Copy link

linear bot commented Jan 13, 2025

@SokratisVidros
Copy link
Contributor

Hey @david-morris! Thanks for reporting this.

We've recently released Novu , that will supersede the @novu/notification-center package. Would you consider migrating to Inbox instead? I am also sharing the official migration guide.

@SokratisVidros SokratisVidros closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants