-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The disabled
property is not working.
#41
Comments
Hi @cainmagi , You're right, looking at the Upload_ReactComponent.react.js shows that there is a disabledClass argument for the Looking at elsewhere of the const getClass = () => {
if (this.props.disabledInput) {
return this.props.disableClass;
} else if (this.state.isHovered) {
return this.props.hoveredClass;
} else if (this.state.isUploading) {
return this.props.uploadingClass;
} else if (this.state.isComplete) {
return this.props.completeClass;
} else if (this.state.isPaused) {
return this.props.completeClass;
}
return this.props.className
Personally I don't have currently need for the disabledClass, but I could fix these typos. Although, I don't know how disabling the component should work. What is your use case? What kind of changes you would like to have? |
Thank you. Could you fix the typos first? After that, I could start to implement the The reason why I need
By the way, I guess the reason why there is no error with the typo is that the property Certainly, I could wrap the component with a |
The fixes are added in the It seems like a good idea. Also there might be need for additional parameter like |
Thank you! I will try to implement this feature. Once I finish it, I will start a PR. It is a good change for me to learn how to develop a customized dash component 😏. |
I have just confirmed that the property
Edit: I have already known how to handle this problem. I should add a check followed by |
Have finished the PR. See #42. |
The
dcc.Upload
could be disabled by setting the propertydisabled=True
. The source codes show thatdu.Upload
provides a propertydisabledClass
(see here). However, currentlydu.Upload
does not supportdisabled
argument, which makesdisabledClass
useless.I am working with this extension for building my own project now. I wonder if the author is interested in fixing this problem. If not, I could start a pull request for it.
The text was updated successfully, but these errors were encountered: