Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass flatOptions through to Arborist.reify in npm ci #2159

Closed
wants to merge 1 commit into from
Closed

fix: pass flatOptions through to Arborist.reify in npm ci #2159

wants to merge 1 commit into from

Conversation

darcyclarke
Copy link
Contributor

Fixes: #2017

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Nov 12, 2020
@darcyclarke darcyclarke requested a review from a team as a code owner November 12, 2020 00:13
darcyclarke added a commit that referenced this pull request Nov 13, 2020
@darcyclarke
fix: pass flatOptions through to Arborist.reify in npm ci
823f99d 
Fixes: #2017

Credit: @darcyclarke
Close: #2159
Reviewed-by: @ruyadorno
@isaacs isaacs closed this in 786e364 Nov 13, 2020
@darcyclarke darcyclarke mentioned this pull request Nov 13, 2020
Closed
@nlf nlf deleted the darcyclarke/pass-flatoptions-in-ci branch March 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm ci ignores --production flag and always installs devDependencies.
2 participants
@darcyclarke @ruyadorno