Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] progress=false is ignored on npm 7 #2560

Closed
mafintosh opened this issue Jan 28, 2021 · 7 comments
Closed

[BUG] progress=false is ignored on npm 7 #2560

mafintosh opened this issue Jan 28, 2021 · 7 comments
Labels
Bug thing that needs fixing Priority 2 secondary priority issue Release 7.x work is associated with a specific npm 7 release

Comments

@mafintosh
Copy link

mafintosh commented Jan 28, 2021

Current Behavior:

Have an .npmrc with progress=false for aesthetic reasons.
On npm6 that disables the progress bar, on npm7 it does not although the docs say it still should.

This is my full .npmrc if that helps

loglevel=http
progress=false
package-lock=false
save=false

Expected Behavior:

Expected the above to disable the progress bar like it does on 6

Steps To Reproduce:

Save the .npmrc in home and install something. Progress bar is still shown.

Environment:

  • OS: macOS big sur
  • Node: 15.7.0
  • npm: 7.4.3
@mafintosh mafintosh added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Jan 28, 2021
@wraithgar wraithgar added Priority 2 secondary priority issue and removed Needs Triage needs review for next steps labels Feb 2, 2021
@luisthedragon
Copy link

Same problem here, I have triedmany ways:

  • inline (npm install --no-progress)
  • in root folder (via .npmrc with progress=false)
  • in my user folder (via .npmrc with progress=false)

I have also tried reinstalling node. Even reinstalling npm from the github page.
But I keep getting the same result.

Environment:

  • OS: Windows 10 Home
  • Node: 14.15.4
  • npm: 7.5.2

@icatalina
Copy link

icatalina commented Feb 9, 2021

You can achieve something similar by piping the command through tee.

npm ci 2>&1 | tee

Not the best solution, but at least you don't get the progress... 🤷

@silverwind
Copy link

Neiter progress nor loglevel have any effect on the progress line any more. I hope it's not a performance bottleneck like past progress lines were.

@blimmer
Copy link

blimmer commented May 12, 2021

I noticed a ton of output in my CI system from this now. I think the progress was automatically disabled on non-interactive terminals before. Maybe it's related to this?

found 0 vulnerabilities
[         .........] / idealTree: timing idealTree Completed in 15ms
[         .........] / idealTree: timing idealTree Completed in 15ms
[         .........] / idealTree: timing idealTree Completed in 15ms
[         .........] / idealTree: timing idealTree Completed in 15ms
[         .........] - reify:fsevents: sill reify mark deleted [
[         .........] - reify:fsevents: sill reify mark deleted [
[         .........] - reify:fsevents: sill reify mark deleted [
[         .........] | reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] / reify:fsevents: sill reify mark deleted [
[         .........] - reify:fb-watchman: sill tarball no local data for @apoll
[          ........] \ reify:yocto-queue: timing reifyNode:node_modules/@oclif/
[           .......] \ reify:@babel/code-frame: timing reifyNode:node_modules/@
[           .......] / reify:ansi-styles: timing reifyNode:node_modules/ansi-es
[           .......] / reify:binary-extensions: timing reifyNode:node_modules/c
[           .......] - reify:jsonfile: timing reifyNode:node_modules/@oclif/plu
[           .......] - reify:chalk: timing reifyNode:node_modules/@oclif/color/
[           .......] \ reify:@babel/helper-module-imports: timing reifyNode:nod
[            ......] / reify:@babel/helper-validator-identifier: timing reifyNo
[            ......] / reify:emoji-regex: timing reifyNode:node_modules/glob Co
[            ......] - reify:emoji-regex: timing reifyNode:node_modules/buffer
[            ......] | reify:tslib: timing reifyNode:node_modules/@babel/templa
[            ......] - reify:function-bind: timing reifyNode:node_modules/picom
[            ......] | reify:tslib: timing reifyNode:node_modules/@graphql-code
[            ......] - reify:agent-base: timing reifyNode:node_modules/lower-ca
[            ......] | reify:argparse: timing reifyNode:node_modules/chokidar C
[            ......] / reify:param-case: timing reifyNode:node_modules/chardet
[            ......] \ reify:external-editor: timing reifyNode:node_modules/is-
[            ......] - reify:tty: http fetch GET 200 https://registry.npmjs.org
[            ......] \ reify:fast-json-stable-stringify: timing reifyNode:node_
[            ......] / reify:unixify: http fetch GET 200 https://registry.npmjs
[            ......] / reify:widest-line: http fetch GET 200 https://registry.n
[            ......] | reify:slice-ansi: http fetch GET 200 https://registry.np
[            ......] | reify:setimmediate: http fetch GET 200 https://registry.

As mentioned above, I wonder if this is accounting for poor performance as in previous NPM versions.

@mafintosh
Copy link
Author

Anyway to disable the progress bar now through other means?

@cong-min
Copy link

same problem

@wraithgar
Copy link
Member

Closing in favor of #3314, which has information on where the bug may actually lie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 2 secondary priority issue Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

7 participants