[BUG] exec/npx: npm v8.8+/9+ break with a self-reference

[ljharb]

Is there an existing issue for this?

• I have searched the existing issues

This issue exists in the latest npm version

• I am using the latest npm

Current Behavior

In a package foo with a bin, run npx foo, and you'll see sh: foo: command not found.

Expected Behavior

In a package foo with a bin, run npx foo, and the bin is invoked.

Steps To Reproduce

1. Clone any repo, presumably, but in this case, https://github.com/ljharb/publishers
2. Run npx [email protected] exec publishers, see that it invokes the binary properly.
3. Run npx [email protected] exec publishers, see that it errors.

Environment

• npm: <= 8.7, >= 8.8
• Node.js: 19

[wraithgar]

Duplicate of #5730

[wraithgar]

Nope sorry wrong issue

[ljharb]

Yay, thanks!

[lukekarrys]

Running the original steps to reproduce, I get a different error with 9.1.1:

❯ npx --version
9.1.1

❯ pwd
/Users/lukekarrys/projects/ljharb/publishers

❯ npx publishers
node:internal/modules/cjs/loader:998
  throw err;
  ^

Error: Cannot find module 'json-colorizer'
Require stack:
- /Users/lukekarrys/projects/ljharb/publishers/bin/publishers
    at Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
    at Module._load (node:internal/modules/cjs/loader:841:27)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/Users/lukekarrys/projects/ljharb/publishers/bin/publishers:5:18)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/Users/lukekarrys/projects/ljharb/publishers/bin/publishers' ]
}

Node.js v18.12.1

[ljharb]

Thanks for noticing; I hadn't had a chance to verify yet.

[ljharb]

Confirmed that my issue is fixed as of v9.1.1, but this can stay open til #5842 lands.