This repository has been archived by the owner on May 10, 2021. It is now read-only.
delete contents of node_modules but keep the dir itself #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tareksha
changed the title
tareksha
changed the title
|
lgtm |
|
running into this issue myself |
claudiahdz
pushed a commit
that referenced
this pull request
Oct 8, 2019
PR-URL: #1 Credit: @tareqhs Close: #1 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 8, 2019
PR-URL: #1 Credit: @tareqhs Close: #1 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 8, 2019
PR-URL: #1 Credit: @tareqhs Close: #3 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 8, 2019
PR-URL: #1 Credit: @tareqhs Close: #3 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #1 Credit: @tareqhs Close: #1 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #1 Credit: @tareqhs Close: #1 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #1 Credit: @tareqhs Close: #1 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #1 Credit: @tareqhs Close: #1 Reviewed-by: @claudiahdz
cpennington
added a commit
to cpennington/configuration
that referenced
this pull request
Nov 4, 2019
…en node_modules is mounted (like in docker) 12.13.0 is the first version of node that includes npmcli 4.0.7, which includes npm/libcipm#1, which means that `npm ci` will work correctly in circumstances where `node_modules` is mounted rather than being a standard directory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: zkat/cipm#47
Keep node_modules directory but delete its contents.
In some CI setups node_modules is a special directory, e.g. a mounted folder or a symbolic link. For these setups simply deleting node_modules won't work, or worse will work but break the CI setup. Deleting node_modules is a also a non-trivial deviation from the expected behavior of npm install which means the existing CI setups that are explained above are blocked from migrating to npm ci.
npm ci should minimize violent changes and concentrate on the fact we want to reset the installed dependencies and proceed with the regular flow. Keep node_modules untouched, doesn't matter how it was created.