Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe-buffer dependency is missing from package.json #3

Closed
dashea opened this issue Nov 17, 2018 · 1 comment · Fixed by #5
Closed

safe-buffer dependency is missing from package.json #3

dashea opened this issue Nov 17, 2018 · 1 comment · Fixed by #5
Assignees
@ruyadorno

Comments

@dashea
Copy link

dashea commented Nov 17, 2018

The dependency was removed in c5ab01f, but index.js still includes a require('safe-buffer'). npm-registry-fetch will fail to load if dependencies are not flattened when installed to node_modules.
evocateur added a commit to evocateur/npm-registry-fetch that referenced this issue May 8, 2019
@evocateur
fix(deps): Add explicit dependency on safe-buffer
7144d0f 
This removes an implicit transitive dependency that itself relies on node_modules being flattened by package managers.

Without this explicit dependency, stricter package managers like pnpm fail to install a usable copy of this library.

Refs npm/libnpmaccess#2
Fixes npm#3
@evocateur evocateur mentioned this issue May 8, 2019
Merged
evocateur added a commit to evocateur/npm-registry-fetch that referenced this issue May 8, 2019
@evocateur
fix(deps): Add explicit dependency on safe-buffer
5e1c99b 
This removes an implicit transitive dependency that itself relies on node_modules being flattened by package managers.

Without this explicit dependency, stricter package managers like pnpm fail to install a usable copy of this library.

Refs npm/libnpmaccess#2
Fixes npm#3
@GongT
Copy link

GongT commented Jul 2, 2019 •
edited
Loading

+1

Please merge that PR.

evocateur added a commit to evocateur/npm-registry-fetch that referenced this issue Jul 15, 2019
@evocateur
fix(deps): Add explicit dependency on safe-buffer
ecffe97 
This removes an implicit transitive dependency that itself relies on node_modules being flattened by package managers.

Without this explicit dependency, stricter package managers like pnpm fail to install a usable copy of this library.

Refs npm/libnpmaccess#2
Fixes npm#3
evocateur added a commit to evocateur/npm-registry-fetch that referenced this issue Jul 16, 2019
@evocateur
fix(deps): Add explicit dependency on safe-buffer
b277470 
This removes an implicit transitive dependency that itself relies on node_modules being flattened by package managers.

Without this explicit dependency, stricter package managers like pnpm fail to install a usable copy of this library.

Refs npm/libnpmaccess#2
Fixes npm#3
ruyadorno pushed a commit that referenced this issue Sep 13, 2019
@evocateur @ruyadorno
fix(deps): Add explicit dependency on safe-buffer
8eae5f0 
This removes an implicit transitive dependency that itself relies on node_modules being flattened by package managers.

Without this explicit dependency, stricter package managers like pnpm fail to install a usable copy of this library.

Refs npm/libnpmaccess#2
Fixes #3
This was referenced Mar 6, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): Add explicit dependency on safe-buffer evocateur/npm-registry-fetch
4 participants
@ruyadorno @darcyclarke @GongT @dashea