Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhantomData detection is brittle #34

Open
eira-fransham opened this issue Mar 19, 2018 · 1 comment
Open

PhantomData detection is brittle #34

eira-fransham opened this issue Mar 19, 2018 · 1 comment

Comments

@eira-fransham
Copy link

Currently it will generate false positives on cases like:

struct PhantomData;

#[derive(new)]
struct Foo { bar: PhantomData }

and false negatives on cases like:

use std::marker::PhantomData as PD;

#[derive(new)]
struct Foo { bar: PD }
@Lucretiel
Copy link
Contributor

Unfortunately, this isn't possible to solve with a proc macro. Proc macros run before any useful type information is available, so the only thing they have to go on is the actual type names that are present in the definition of the decorated type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants