-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure all embedded-hal interfaces can implicitly copy #150
Comments
Instead of returning Error::DMABufferNotInDataMemory? |
I think the majority vote was in favor of returning an Error on the main interface but providing a call which does implicit copy if you ask it to. |
The goal was:
This is because some (non nrf specific) drivers send constant strings, which will end up in |
Oups, i messed up my first PR and accidently pushed the wrong branch, still getting used to the workflow of contributing, haha! Anyways, i now submitted the one i was supposted to (PR #164) for spim transfer :) |
Added Twim write/write_read aswell and made a new PR #165 with both Spim and Twim instead, sorry for the PR mess, i'm new here... :) (Not sure why the githud build failed (##[error]Process completed with exit code 1), is that a common issue or is it me? It builds just fine on my machine...) |
For compat reasons, we should support implicit copy (if the user passes in a slice from
.text
) of chunks on all interfaces. We currently do this for UARTE, but not for SPIM/TWIM.The text was updated successfully, but these errors were encountered: