-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NestJs need to have es6 in tsconfig target #1002
Comments
Just to add onto this. |
Hey guys. I opened a PR #1770 I created a brand new nest app with the nest cli and compared the tsconfig @Toxicable I would recommend sticking to the target version nestjs uses. At the time being it is |
@mehrad-rafigh Hi, that's exactly what I was looking for :) Plus I agree to the fact that we should stick to nestjs' es version. |
Folks. Is it still an issue? |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Prerequisites
Please answer the following questions for yourself before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.
Expected Behavior
I merged my api repository using nest to my nrwl repository with the 7.3 version.
The ng serve nestjs-project is suppose to correctly run the API
Current Behavior
Nest wasn't able to handle request when using Nest middleware (infinite loading).
I found out the issue : nestjs/nest#266.
Nestjs need to have tsconfig target set to es6, but by default the tsconfig generated by nrwl inherit from the global tsconfig (es5).
Other
I think it would be nice to override nrwl default tsconfig with the default nestjs tsconfig options when generating a new nestjs project
The text was updated successfully, but these errors were encountered: