Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

producer: use "clean close" #103

Closed
mreiferson opened this issue Jan 22, 2015 · 1 comment
Closed

producer: use "clean close" #103

mreiferson opened this issue Jan 22, 2015 · 1 comment
Labels
bug

Comments

@mreiferson
Copy link
Member

Right now it's just closing the connection, causing spurious errors in nsqd logs (see nsqio/nsq#521)

It should send a CLS command and wait for the appropriate response before closing the connection, like Consumer already does.

cc @tj
@mreiferson mreiferson added the bug label Jan 22, 2015
@mreiferson mreiferson changed the title Producer should use "clean close" producer: use "clean close" Jul 15, 2015
@mreiferson
Copy link
Member Author

closing this, we addressed this on the nsqd side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mreiferson