Missing tools from PackageDownload when publishing as global tool

[yang-xiaodong]

Description

GitVersion does not work when packaged as dotnet tools for sharing in a team.
The error message is Could not find package 'GitVersion.Tool', or 'GitVersion.CommandLine'

Steps to reproduce

1. The tools project named MyCommand.csproj

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
    <PackAsTool>True</PackAsTool>
    <IsPackable>True</IsPackable>
    <ToolCommandName>mycommand</ToolCommandName>
    <PackageOutputPath>./../artefacts</PackageOutputPath>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Nuke.Common" Version="0.24.0" />
    <PackageDownload Include="GitVersion.Tool" Version="[5.1.1]" />
  </ItemGroup>

2. Build.cs code under the MyCommand.csproj

class Build : NukeBuild
{
    public static int Main() => Execute<Build>(x => x.ShowVersion);

    [GitVersion] GitVersion GitVersion;

    Target ShowVersion => _ => _
        .Executes(() =>
        {
            Logger.Success("Current Version: " + GitVersion.SemVer);
        });
}

3. Pack the dotnet tools project MyCommand.csproj and push to nuget server

> dotnet pack MyCommand.csproj 
> dotnet nuget push -s http://192.168.xxx.xxx/v3/index.json ..\artefacts\MyCommand.1.0.0.nupkg

4、Install as the dotnet tool and execute to show the version

> dotnet tool install -g --add-source http://192.168.xxx.xxx/v3/index.json MyCommand
> mycommand showversion

Then the error will be raised

Relevant log output

NUKE Execution Engine version 0.24.0 (Windows,.NETCoreApp,Version=v3.0)

Assertion failed: Could not find package 'GitVersion.Tool', or 'GitVersion.CommandLine' using:
 - Embedded packages directory at ''
   at Nuke.Common.ControlFlow.Fail(String text)
   at Nuke.Common.Tooling.ToolPathResolver.GetPackageDirectory(String[] packageIds, String version)
   at Nuke.Common.Tooling.ToolPathResolver.GetPackageExecutable(String packageId, String packageExecutable, String version, String framework)
   at Nuke.Common.Tools.GitVersion.GitVersionTasks.GetToolPath(String framework)
   at Nuke.Common.Tools.GitVersion.GitVersionSettings.GetToolPath()
   at Nuke.Common.Tools.GitVersion.GitVersionSettings.get_ToolPath()
   at Nuke.Common.Tooling.ProcessTasks.StartProcess(ToolSettings toolSettings)
   at Nuke.Common.Tools.GitVersion.GitVersionTasks.GitVersion(GitVersionSettings toolSettings)
   at Nuke.Common.Tools.GitVersion.GitVersionTasks.GitVersion(Configure`1 configurator)
   at Nuke.Common.Tools.GitVersion.GitVersionAttribute.GetValue(MemberInfo member, Object instance)
   at Nuke.Common.Execution.InjectionUtility.InjectValuesInternal[T](T instance, IEnumerable`1 tuples)
   at Nuke.Common.Execution.InjectionUtility.InjectValues[T](T instance, Func`2 filter)
   at Nuke.Common.Execution.BuildManager.Execute[T](Expression`1[] defaultTargetExpressions)

[matkoch]

Could you please star the project?

[yang-xiaodong]

Sure, :)
By the way , it works in visual studio

[yang-xiaodong]

If needed, I can help write a blog and publicity in China .net community website. I have about 2000+ followers of .net fans

[matkoch]

@yang-xiaodong sure, always welcome :)

what do you mean, what works in Visual Studio?

[yang-xiaodong]

Source code in visual studio, click nuke icon and debug can print the version, no error!

[matkoch]

Yes. That works different than after installing as global tool.

[matkoch]

For now I suggest to switch to PackageReference with ExcludeAssets=all. That should work, afaik.

[yang-xiaodong]

@matkoch Thanks for your answer, I tried the suggested way you pointed, it doesn't seem to work for me, am I missing something?

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
    <PackAsTool>True</PackAsTool>
    <IsPackable>True</IsPackable>
    <ToolCommandName>mycommand</ToolCommandName>
    <PackageOutputPath>./../artefacts</PackageOutputPath>
    <Version>1.0.4</Version>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Nuke.Common" Version="0.24.0" />

<!--<PackageDownload Include="GitVersion.Tool" Version="[5.1.1]" />-->
    <PackageReference Include="GitVersion.Tool" Version="5.1.1">
      <ExcludeAssets>all</ExcludeAssets>
    </PackageReference>    
  </ItemGroup>
</Project>

[cmenzi]

Maybe some information on this:

• PackageReference defined in .props file not appearing in project.assets.json when using dotnet restore NuGet/Home#9132 (comment)

When you're using <ExcludeAssets>all</ExcludeAssets> the references don't get packed into nuget.

I've nearly managed it though .props file. See here: #396

Another option regarding this: NuGet/Home#9132 (comment) is not using `.

Suggestion from nuget team is to use https://github.com/microsoft/MSBuildSdks

GitHub

microsoft/MSBuildSdks

MSBuild project SDKs. Contribute to microsoft/MSBuildSdks development by creating an account on GitHub.

[krankenbro]

I had the same problem. The found workaround is to add constructor

public Build()
{
        ToolPathResolver.ExecutingAssemblyDirectory = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
}

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.