Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] Lacking result url for “Share and explore” network action #1747

Closed
sync-by-unito bot opened this issue Jun 30, 2022 · 18 comments
Closed

[issue] Lacking result url for “Share and explore” network action #1747

sync-by-unito bot opened this issue Jun 30, 2022 · 18 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jun 30, 2022

sherry
capture app
issues :Lacking result url for “List in CaptureClub” network action
expectation:Can see result url after complete “List in CaptureClub” network action
steps to reproduce:1. open Capture App

  1. Select a photo
  2. Choose Network Action -> List in CaptureClub
  3. Wait for the process complete, go to the activity page and check for the result

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

@sync-by-unito sync-by-unito bot changed the title Lacking result url for “List in CaptureClub” network action [issue] Lacking result url for “List in CaptureClub” network action Sep 29, 2022
@sync-by-unito sync-by-unito bot changed the title [issue] Lacking result url for “List in CaptureClub” network action [issue] Lacking result url for “Share and explore” network action Oct 4, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Sam commented:

Scott Yan Is "List in CaptureClub" is missing or I'm looking at the wrong place? [claap ( https://app.claap.io/numbers-protocol/dev-list-in-capture-club-is-missing-c-O35CsUM4Uy-ojtT_D4vrqZg )]

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Scott Yan commented:

Sam Reply at claap

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Sam commented:

Ethan Wu, I have a question regarding network action “List in CaptureClub“ aka “Mint and Share“.
From the ionic side, we only send a request to "Mint and Share" and the rest of the work is done on Bubble side + (maybe some other backend service) right?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Sam commented:

Ethan Wu, here is the claap ( https://app.claap.io/numbers-protocol/dev-is-bubble-api-missing-request-url-c-O35CsUM4Uy-4Zbz1TYfntNw ) version.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Sam commented:

Ethan Wu, I think I got it please ignore my last two comments.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 25, 2022

➤ Tammy Yang commented:

Sam I think you need to wait until [FR] Allow asset page to be shared independently ( https://app.asana.com/0/1201016280880500/1203034547987479/f ) is done because the URL should link to the asset page.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 27, 2022

➤ Kenny Hung commented:

changed due day to 11/1.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam based on the social share flow the link that will be shared is the nse asset profile link

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Sam commented:

Here is the PR ( #2249 )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Sam commented:

Ethan Wu, this fix can be released today right? Because it seems blocked by [FR] Allow asset page to be shared independently ( https://app.asana.com/0/1201016280880500/1203034547987479/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 1, 2022

➤ Ethan Wu commented:

Sam yes. i am working on this one now.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Scott Yan commented:

SamEthan Wu is this task completed? If it is completed, please help to change the status. Thank you

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Ethan Wu commented:

Scott Yan iframe with social share feature hasn't been deployed yet. there is a code review fix pending with retest scheduled for tuesday.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 21, 2022

➤ Sherry Chung commented:

Kenny Hung Please check if this also include in Capture v221115-iframe release or v221115 ionic release

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sherry Chung commented:

Sam (cc Kenny Hung ) this is a unfinished item from sprint 22.11.07. I moved it to sprint 22.11.21. please confirm.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

This has been finished on 0.69.x

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sherry Chung commented:

Great. I'll revert the change.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sherry Chung commented:

Sam Please complete the task if it's finished.

@sync-by-unito sync-by-unito bot closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant