-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The --teamcity option silently fails if the extension is not installed #1507
Comments
This issue has been resolved in version 3.19.0 The release is available on: |
We're seeing this new I've switched back to 3.18.3 for now and everything is working. |
@Quppa Are you using the standard runner or the .NET Core (.NET 8.0) runner? Did you install NUnit.Console or NUnit.ConsoleRunner? Are you running under TeamCity? Or did you use the option on the command-line? (The option is assumed if you run under TeamCity? You could either provide more info in a new issue or provide it here so we can decide if you should create one. |
|
I believe NUnit Legacy refers to NUnit V2. That's not what you are running, since we know you are using 3.19. Since it's .NET Framework, then it has to be the standard runner. If you have a way to do it, run nunit3-console --list-extensions in the same environment. In fact, it wouldn't hurt to run it all the time prior to running your actual tests. If the teamcity extension is not installed, that's one problem, if it is we have a different problem. Note that if 3.18.3 is working for you, it's because it doesn't give an error message when the extension is missing. We have another issue where I'm learning that folks running under teamcity do not always need to use the extension. |
I have the same problem and here is my output from nuint3-console --list-extensions command: C:\TeamCity\buildAgent\tools\NUnit.Console.3.19.0\bin\net462> nunit3-console --list-extensions Runtime Environment Installed Extensions i've also tried to 'install' extension with the .addins file described here and result is the same - the list of installed extension as above and the error message in teamcity build (Option --teamcity specified but TeamCityEventListener is not installed.). by the way - if i switch to the 'standard' Nuint runner - i have the same problem with different message: the link doesn't explain how to install this extension either |
Having reviewed the links provided by @ohnefuenfter, I have realized that the term "Legacy NUnit" means something different to JetBrains than it does to the NUnit team. Ignore my earlier comment about that. It also appears that "standard runner" may mean something else to the company than it does to me, so I'll stop using that term in this thread. From this discussion so far, one thing is clear... the error message is being correctly displayed because the extension is not actually installed. So we have a different problem, which is probably related to the fact that the 3.19 release changed how extensions are located. See issue #1504. A stated in the issue, I suggest two steps to resolve this...
|
Based on the code as well as my memory, this was intentional. Assuming the user is running interactively, it makes sense to just go ahead and run and hopefully it will be clear that the extension is missing. But of course --teamcity is not normally used interactively but when running on a CI server.
It now seems better to me to give an error message and stop the run if the extension is not available.
@OsirisTerje @veleek @NikolayPianikov Does that make sense to you?
The text was updated successfully, but these errors were encountered: