Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit test is skipped, but is marked as "success" in TeamCity. #1229

Closed
ds-ms2soft opened this issue Jan 15, 2025 · 2 comments
Closed

Explicit test is skipped, but is marked as "success" in TeamCity. #1229

ds-ms2soft opened this issue Jan 15, 2025 · 2 comments
Labels
closed:SomebodyElsesProblem Closed because there is nothing we can do, as this is caused by an external component Investigate

Comments

@ds-ms2soft
Copy link

NUnit Version: 3.13.3
NUnit3TestAdapter Version: 4.6.0
TeamCity Professional 2024.12 (build 174331)
.Net Framework 4.8
dotnet version: 8.0.403

We have tests that are marked as [Explicit]. These are being ignored correctly (they don't run; verified by an Assert.Fail), but they appear as "success" in TeamCity rather than ignored.
@OsirisTerje
Copy link
Member

OsirisTerje commented Feb 4, 2025 •
edited
Loading

Can you repro this on the command line, checking out what TeamCity actually do when they call the adapter?
Also, enable the Dump feature (using command line parameter for that, or a runsettings file) and check what is in the dump file.

See https://docs.nunit.org/articles/vs-test-adapter/Tips-And-Tricks.html#dumpxmltestdiscovery-and-dumpxmltestresults for details.

OR WAIT:

Do you mean, they DON'T run, but TeamCIty is showing them as runned with success ?
If that is so, then there is a bug in TeamCity, not respecting the status for those tests (which is "Skipped").

@OsirisTerje OsirisTerje added Investigate closed:SomebodyElsesProblem Closed because there is nothing we can do, as this is caused by an external component labels Feb 4, 2025
@OsirisTerje
Copy link
Member

@ds-ms2soft Would be nice if you added a link to the JetBrains issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed:SomebodyElsesProblem Closed because there is nothing we can do, as this is caused by an external component Investigate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OsirisTerje @ds-ms2soft