Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #461 Fix Causes Build Error (Somewhat Indirectly) #490

Closed
TheAjItator opened this issue Mar 22, 2018 · 4 comments
Closed

Issue #461 Fix Causes Build Error (Somewhat Indirectly) #490

TheAjItator opened this issue Mar 22, 2018 · 4 comments
Milestone

Comments

@TheAjItator
Copy link

In issue #461, where the .pdb file was added to the nuget package specifically, causes a build breakage on my company's build server.

My SCM engineer tells me that coverage tool runs coverage on the 3rd party .pdb files in the output.
This throws off the code metrics when they exist in the output directory. Therefore they delete all .pdb files after installing packages. Unfortunately the recent change to the NUnit3TestAdapter.props file now requires that the .pdb be copied. The build cannot, so an error is raised.
This hasn't been an issue for other builds so I believe this hasn't been an issue with other libraries.

I see that NUnit has the .pdb files in the nuget package in a lib folder instead of a build folder and the NUnit.props file doesn't instruct the build to copy the .pdb file. (Just to compare with a sister project.)

I've also seen suggestions that a nuget symbols package might be the suggested way to add debugging info. Stackoverflow.com item.
The MS article on symbols packages is: Creating symbol packages

For reference, NUnit v3.10.1 and NUnit3TestAdapter v3.10.0

Any chance that the nuget package could be updated to not have the .pdb directly or require it be copied to the build output?

Thanks!

@rprouse
Copy link
Member

rprouse commented Mar 23, 2018

@jnm2 can you take a look at this?

@jnm2
Copy link
Contributor

jnm2 commented Mar 23, 2018

@TheAjItator Is the build error due to the fact that the source PDB file has been deleted and cannot be copied? Or is the problem that your tool is not deleting the PDB and it is actually showing up in build output and messing up your code coverage tool?

@TheAjItator
Copy link
Author

@jnm2 The error is because the files are deleted and cannot be copied.

@jnm2
Copy link
Contributor

jnm2 commented Mar 23, 2018

Great! It seems like we have a simple workaround, if @OsirisTerje thinks #492 is something we want to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants