Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate error message when calling register after sign-in #6021

Open
nus-se-script opened this issue Nov 17, 2023 · 1 comment
Open

Inaccurate error message when calling register after sign-in #6021

nus-se-script opened this issue Nov 17, 2023 · 1 comment

Comments

@nus-se-script
Copy link

nus-se-script commented Nov 17, 2023

I followed the User Guide by creating a new account with the following commands:
register --user yourUsername --password AlexIsGreat --confirmPass AlexIsGreat --secretQn First Pet Name? --answer Koko

After sign-in, I tried to execute the same command with different confirmed password. As given below,
register --user yourUsername --password AlexIsGreat --confirmPass AlexIsGrea --secretQn First Pet Name? --answer Koko
The application threw an error with the following message:
Passwords do not match. Please try out again.
Even though the confirmed password doesn't match the password, I think this error shouldn't have a higher priority than the multiple account error. It makes more sense to throw an error indicating that user is not allowed to create multiple accounts.
Screenshot 2023-11-17 at 4.29.04 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#6014] [original labels: type.FunctionalityBug severity.High]
@juliusgambe
Copy link
Contributor

Team's Response

This is a low FeatureFlaw because it does not hinder the ability of the user to register but only brings it slight inconvience.

However, this is part of planned enhancements #5 where we stated that currently there is no precedence of errors (ie. priority of errors) and we want to put errors of higher importance such as this first.

Screenshot 2023-11-19 at 11.15.33 PM.png

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants