Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalSearch options have poor readability in screen readers #3010

Closed
taneliang opened this issue Dec 3, 2020 · 1 comment · Fixed by #3022
Closed

GlobalSearch options have poor readability in screen readers #3010

taneliang opened this issue Dec 3, 2020 · 1 comment · Fixed by #3022
Labels
good first issue taken user interface

Comments

@taneliang
Copy link
Member

taneliang commented Dec 3, 2020 •
edited
Loading

See test cases in GlobalSearchContainer.test.tsx.

Context:

Ooof, this is not ideal for screen readers. We should at the very least add a space here, and maybe using some flexbox shenanigans reverse the order of these in the DOM so that it reads more naturally

Originally posted by @ZhangYiJiang in #3007 (comment)
@taneliang taneliang mentioned this issue Dec 3, 2020
Merged
@taneliang taneliang added the taken label Dec 4, 2020
@bingcheng45 bingcheng45 mentioned this issue Dec 4, 2020
Merged
@bingcheng45
Copy link
Contributor

bingcheng45 commented Dec 4, 2020 •
edited
Loading

@taneliang and @ZhangYiJiang I have made a pull request (#3022) for this issue, do review and let me know if further changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue taken user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve GlobalSearch option accessibility bingcheng45/nusmods
2 participants
@bingcheng45 @taneliang