Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repeatable directives #1133

Closed
spawnia opened this issue Jan 11, 2020 · 0 comments · Fixed by #1529
Closed

Support repeatable directives #1133

spawnia opened this issue Jan 11, 2020 · 0 comments · Fixed by #1529
Labels
5.x Related to the 5.x release series enhancement A feature or improvement

Comments

@spawnia
Copy link
Collaborator

spawnia commented Jan 11, 2020

Recently, the GraphQL Spec officially added support for repeatable directives. Since this allows us to depend on the fact that defining multiple directives is generally allowed, we can start using that in Lighthouse.

There are some features that would benefit from having this available:

The current parser already allows to read multiple directives, so we should be able to produce a working implementation. There will have to be some fundamental changes to how we deal with directives.

A proper solution will require incorporating the actual repeatable keyword, including the validation steps that come with it. That part will have to wait on graphql-php supporting it: webonyx/graphql-php#608

@spawnia spawnia added the enhancement A feature or improvement label Jan 11, 2020
@spawnia spawnia added the 5.x Related to the 5.x release series label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x Related to the 5.x release series enhancement A feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant