feat: turn on font stylesheet inlining by default (#87)

This commit enables the "download" option by default, which turns on inlining of the font stylesheet and the downloading/self-hosting of the font. As these are both best practices, it makes sense for these to be part of the default experience. See more: https://web.dev/font-best-practices/#inline-font-declarations Co-authored-by: Ricardo Gobbo de Souza <[email protected]>
nuxt-modules · Jun 9, 2022 · 8b53012 · 8b53012
1 parent 1e50410
commit 8b53012
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 3 deletions.
diff --git a/src/module.ts b/src/module.ts
@@ -28,7 +28,7 @@ const nuxtModule: Module<ModuleOptions> = function (moduleOptions) {
     preconnect: true,
     preload: false,
     useStylesheet: false,
-    download: false,
+    download: true,
     base64: false,
     inject: true,
     overwriting: false,

diff --git a/test/fixture/basic/nuxt.config.js b/test/fixture/basic/nuxt.config.js
@@ -11,6 +11,7 @@ export default {
   googleFonts: {
     families: {
       Roboto: true
-    }
+    },
+    download: false
   }
 }
diff --git a/test/fixture/download/nuxt.config.js b/test/fixture/download/nuxt.config.js
@@ -4,7 +4,6 @@ export default {
     '../../../src/module.ts'
   ],
   googleFonts: {
-    download: true,
     families: {
       Roboto: true
     }

diff --git a/test/fixture/use-stylesheet/assets/css/fonts.css b/test/fixture/use-stylesheet/assets/css/fonts.css
diff --git a/test/fixture/use-stylesheet/nuxt.config.js b/test/fixture/use-stylesheet/nuxt.config.js
@@ -13,6 +13,7 @@ export default {
       Roboto: true
     },
     useStylesheet: true,
+    download: false,
     preload: true
   }
 }