feat!: turn on font stylesheet inlining by default #87
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the "download" option by default, which turns on inlining of the font stylesheet and the downloading/self-hosting of the font. As these are both best practices, it makes sense for these to be part of the default experience. See more: https://web.dev/font-best-practices/#inline-font-declarations
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 45 45
Branches 14 14
=========================================
Hits 45 45
Continue to review full report at Codecov.
|
danielroe
changed the title
danielroe
approved these changes
Jun 9, 2022
ricardogobbosouza
approved these changes
Jun 9, 2022
|
Would be a best practice or not, to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the "download" option by default,
which turns on inlining of the font stylesheet and
the downloading/self-hosting of the font. As these
are both best practices, it makes sense for these
to be part of the default experience.
See more: https://web.dev/font-best-practices/#inline-font-declarations