fix: prevent calling done hook twice

unjs · Nov 9, 2018 · 1753826 · 1753826
1 parent 4e0dc73
commit 1753826
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/plugin.js b/src/plugin.js
@@ -19,6 +19,7 @@ const DEFAULTS = {
 const DEFAULT_STATE = {
   start: null,
   progress: -1,
+  done: false,
   message: '',
   details: [],
   request: null,
@@ -100,7 +101,7 @@ export default class WebpackBarPlugin extends ProgressPlugin {
   }
 
   get hasRunning() {
-    return Object.values(this.states).some((state) => state.progress !== 100);
+    return Object.values(this.states).some((state) => !state.done);
   }
 
   get hasErrors() {
@@ -169,6 +170,11 @@ export default class WebpackBarPlugin extends ProgressPlugin {
     hook(compiler, 'done', (stats) => {
       this._ensureState();
 
+      // Prevent calling done twice
+      if (this.state.done) {
+        return;
+      }
+
       const hasErrors = stats.hasErrors();
       const status = hasErrors ? 'with some errors' : 'succesfuly';
 
@@ -179,6 +185,7 @@ export default class WebpackBarPlugin extends ProgressPlugin {
       Object.assign(this.state, {
         ...DEFAULT_STATE,
         progress: 100,
+        done: true,
         message: `Compiled ${status}${time}`,
         hasErrors,
       });