fix: call done hook last

unjs · Mar 28, 2018 · 642a9ef · 642a9ef
1 parent 6cb41ba
commit 642a9ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -121,8 +121,6 @@ Auto clear console when compile is finished.
 
 A function that will be called when **all** builds are finished.
 
-This function can optionally return `false` as a signal to stop rendering and printing profile stats.
-
 ### `buildTitle`
   - Default: `BUILDING`
 

diff --git a/src/index.js b/src/index.js
@@ -82,20 +82,16 @@ export default class WebpackBarPlugin extends webpack.ProgressPlugin {
       return;
     }
 
-    if (typeof this.options.done === 'function') {
-      const result = this.options.done(sharedState, this);
-      if (result === false) {
-        // Special signal to do nothing
-        return;
-      }
-    }
-
     this.render();
 
     if (this.options.profile) {
       const stats = sharedState[this.options.name].profile.getStats();
       printStats(stats);
     }
+
+    if (typeof this.options.done === 'function') {
+      this.options.done(sharedState, this);
+    }
   }
 
   updateProgress(percent, msg, details) {