feat: upgrade html-validator to v8 version

nuxt-modules · Jun 30, 2023 · 6c696b1 · 6c696b1
1 parent 4e51575
commit 6c696b1
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 65 deletions.
diff --git a/package.json b/package.json
@@ -38,7 +38,7 @@
   "dependencies": {
     "@nuxt/kit": "^3.6.1",
     "chalk": "^5.1.2",
-    "html-validate": "~7.18.0",
+    "html-validate": "~8.0.5",
     "pathe": "^1.0.0",
     "prettier": "^2.7.1",
     "std-env": "^3.3.1"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/runtime/validator.ts b/src/runtime/validator.ts
@@ -27,7 +27,7 @@ export const useChecker = (
 
     // Clean up Vue scoped style attributes
     html = typeof html === 'string' ? html.replace(/ ?data-v-[-A-Za-z0-9]+(=["']([-A-Za-z0-9]|\/|:|\.)*["'])?/g, '') : html
-    const { valid, results } = validator.validateString(html)
+    const { valid, results } = await validator.validateString(html)
 
     if (valid && !results.length) {
       if (logLevel === 'verbose') {

diff --git a/test/validator.test.ts b/test/validator.test.ts
@@ -16,21 +16,21 @@ describe('useValidator', () => {
     expect(validator4).toEqual(validator5)
   })
 
-  it('returns a valid htmlValidate instance', () => {
+  it('returns a valid htmlValidate instance', async () => {
     const validator = getValidator({ extends: ['html-validate:standard'] })
 
-    const { valid, results } = validator.validateString('<!DOCTYPE html><title>x</title>')
+    const { valid, results } = await validator.validateString('<!DOCTYPE html><title>x</title>')
     expect(valid).toBeTruthy()
     expect(results).toEqual([])
 
-    const { valid: invalid, results: invalidResults } = validator.validateString('<!DOCTYPE html><title>x</title><body><a><a>Test</a></a></body>')
+    const { valid: invalid, results: invalidResults } = await validator.validateString('<!DOCTYPE html><title>x</title><body><a><a>Test</a></a></body>')
     expect(invalid).toBeFalsy()
     expect(invalidResults).toMatchSnapshot()
   })
 
-  it('works with default config', () => {
+  it('works with default config', async () => {
     const validator = getValidator(defaultHtmlValidateConfig)
-    const { valid, results } = validator.validateString('<!DOCTYPE html><title>x</title>')
+    const { valid, results } = await validator.validateString('<!DOCTYPE html><title>x</title>')
     expect(valid).toBeTruthy()
     expect(results).toEqual([])
   })