Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Footer icons are partially broken #1475

Closed
TheAlexLichter opened this issue Aug 24, 2022 · 3 comments · Fixed by #1503
Closed

[Docs] Footer icons are partially broken #1475

TheAlexLichter opened this issue Aug 24, 2022 · 3 comments · Fixed by #1503

Comments

@TheAlexLichter
Copy link
Member

TheAlexLichter commented Aug 24, 2022

Reproduction

  1. Check https://content.nuxtjs.org/ in Chrome
  2. See that icons froms NuxtJS and Vue Telescope are missing

  1. Check https://content.nuxtjs.org/ in Firefox
  2. See below
    grafik

Describe the bug

The icons should be there and have acceptable width.
Just set w-6 h-6 as classes 😋

Would create a PR but it seems it is a Docus theme topic and the repo is still private.

Related: #1419

@nobkd
Copy link
Contributor

nobkd commented Aug 24, 2022

Yeah, but I would suggest to use w-5 h-5 because the other social icons are using those too. The view box of the svg icons is not optimal, so they seem smaller when using the same style classes.

I commented this already in this (closed) issue

@TheAlexLichter
Copy link
Member Author

Oh, missed that issue!
Yes, I was thinking about w-6 h-6 too but then they look quite different from the rest.

@nobkd
Copy link
Contributor

nobkd commented Aug 24, 2022

Icon SVG viewBox & class
NuxtJS viewBox="5 23 115 77" class="w-5 h-5"
Vue Telescope viewBox="18 24 88 77" class="w-5 h-5"

is the best I can get with playing around in the browser

Description Image
Icons with the viewBoxes and classes from the table Icons from left to right: NuxtJS, Vue Telescope, Twitter, Github
Same as above with flexbox border displayed Icons from left to right with flexbox border: NuxtJS, Vue Telescope, Twitter, Github

@nobkd nobkd mentioned this issue Sep 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants