Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat(hapi): upgrade to hapi 18 #231

Merged
merged 4 commits into from
May 13, 2019
Merged

feat(hapi): upgrade to hapi 18 #231

merged 4 commits into from
May 13, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 13, 2019

  • Upgrade to @hapi/hapi v18 and add explicitly dependency
  • Use @nuxtjs/hapi instead of hapi-nuxt
  • Improve startup script to use async/await + global rejection handler

@pi0 pi0 changed the title feat: upgrade to hapi 18 feat(hapi): upgrade to hapi 18 May 13, 2019
@pi0 pi0 requested a review from clarkdo May 13, 2019 20:39
@clarkdo clarkdo merged commit 3112b75 into master May 13, 2019
@pi0 pi0 deleted the upgrade-hapi branch May 13, 2019 21:36
@pi0 pi0 mentioned this pull request May 31, 2019
Closed
halimb
halimb reviewed Jun 23, 2019
View reviewed changes
template/frameworks/hapi/server/index.js
host: process.env.HOST || '127.0.0.1',
port: process.env.PORT || 3000
})
function start() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkdo Shouldn't the function be async? (I'm having an error at this line on fresh installs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed. waiting for release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halimb @pi0 v2.8.0 has been released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkdo clarkdo clarkdo approved these changes

@halimb halimb halimb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pi0 @clarkdo @halimb