Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat(ava): add support for ava 3 out-of-the-box #414

Merged
merged 16 commits into from
Jan 31, 2020
Merged

feat(ava): add support for ava 3 out-of-the-box #414

merged 16 commits into from
Jan 31, 2020

Conversation

vinayakkulkarni
Copy link
Contributor

  • update configurations to support Ava 3.0 out of the box for a fresh create-nuxt-app app.

@clarkdo clarkdo changed the title build(ava): add support for ava 3.0 out-of-the-box feat(ava): add support for ava 3.0 out-of-the-box Jan 20, 2020
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except conflicts

@vinayakkulkarni
Copy link
Contributor Author

Found a bug in the configuration from ava 2.x to ava 3.x while performing multiple types of tests (e2e and unit together)

Fixing it here.

@clarkdo clarkdo self-requested a review January 20, 2020 22:12
@vinayakkulkarni vinayakkulkarni changed the title feat(ava): add support for ava 3.0 out-of-the-box feat(ava): add support for ava 3 out-of-the-box Jan 20, 2020
@vinayakkulkarni
Copy link
Contributor Author

Fixed it.

@clarkdo Pl check and review :)

@vinayakkulkarni
Copy link
Contributor Author

Uhh. Any updates?

@clarkdo
Copy link
Member

clarkdo commented Jan 22, 2020

@vinayakkulkarni Sorry, I'll do some local tests tonight.

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In package.json, there is still a script test which will use default ava.config.js.

As the only difference between e2e.config and unit.config is files, so how do you think we use ava.config.js for both of them and set --match='...' in script test:unit and test:e2e ?

@vinayakkulkarni
Copy link
Contributor Author

In package.json, there is still a script test which will use default ava.config.js.

As the only difference between e2e.config and unit.config is files, so how do you think we use ava.config.js for both of them and set --match='...' in script test:unit and test:e2e ?

Hmm.. lemme test it.

@vinayakkulkarni
Copy link
Contributor Author

vinayakkulkarni commented Jan 29, 2020

--match matches the file names.

PS. Ava also accepts glob patterns in parameter, I've updated it here

Tested it from my side

@vinayakkulkarni
Copy link
Contributor Author

@clarkdo : can you please review/test?

@clarkdo clarkdo merged commit 0e14a6f into nuxt:master Jan 31, 2020
@clarkdo
Copy link
Member

clarkdo commented Jan 31, 2020

Thanks!

@vinayakkulkarni vinayakkulkarni deleted the fix/upgrade-scaffolded-ava-config branch February 1, 2020 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants