-
-
Notifications
You must be signed in to change notification settings - Fork 427
feat(ava): add support for ava 3 out-of-the-box #414
feat(ava): add support for ava 3 out-of-the-box #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except conflicts
Found a bug in the configuration from ava 2.x to ava 3.x while performing multiple types of tests (e2e and unit together) Fixing it here. |
- `import` & `require()` not yet supported properly in ava v3.0 config files
Fixed it. @clarkdo Pl check and review :) |
Uhh. Any updates? |
@vinayakkulkarni Sorry, I'll do some local tests tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In package.json, there is still a script test
which will use default ava.config.js.
As the only difference between e2e.config and unit.config is files, so how do you think we use ava.config.js
for both of them and set --match='...'
in script test:unit
and test:e2e
?
Hmm.. lemme test it. |
--match matches the file names. PS. Ava also accepts glob patterns in parameter, I've updated it here Tested it from my side |
@clarkdo : can you please review/test? |
Thanks! |
create-nuxt-app
app.