This repository was archived by the owner on Mar 4, 2025. It is now read-only.
feat: add Nightwatch.js as test framework option #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkdo
approved these changes
Jul 27, 2020
|
Do you mind resolving the conflicts so we can merge it? |
|
No problem @atinux I'll check it this evening or tomorrow and rebase this branch with master resolving the conflict. |
astagi
force-pushed
the
feature/nightwatchjs
branch
from
aaafa12 to
4cf9466
Compare
atinux
approved these changes
Jul 30, 2020
astagi
force-pushed
the
feature/nightwatchjs
branch
from
4cf9466 to
7b7f883
Compare
clarkdo
approved these changes
Sep 28, 2020
renovate.json
Outdated
| @@ -57,6 +57,10 @@ | |||
| { | |||
| "packagePatterns": ["wdio", "webdriver"], | |||
| "groupName": "webdriverio packages" | |||
| }, | |||
| { | |||
| "packagePatterns": ["nightwatch"], | |||
There was a problem hiding this comment.
Should chromedriver be included ?
There was a problem hiding this comment.
yes, it needs at least one driver to run tests, chromedriver is the most common one.
There was a problem hiding this comment.
@clarkdo sorry I replied too fast here! I've just added chromedriver in renovate.json, I forgot to add it before!
|
@astagi I've updated snapshot job, can you please merge latest master and try ? |
astagi
force-pushed
the
feature/nightwatchjs
branch
from
7b7f883 to
b586810
Compare
astagi
force-pushed
the
feature/nightwatchjs
branch
from
b586810 to
1e790b4
Compare
|
Thanks! @astagi |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Nightwatch.js as test framework option 🦉