This repository was archived by the owner on Mar 4, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-linting directly before pushing did the trick. Life of a Windows dev 😁 |
I'm now realising that these tests are auto-generated 😂 |
All good to review now 😜 |
pi0
reviewed
Aug 31, 2020
{ name: 'None', value: 'none' }, | ||
{ name: 'Git', value: 'git' } | ||
], | ||
default: 'none' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to keep default as git
like before? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pi0
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks ❤️
thank you. this was my first open source contribution to a mainstream repo, so cheers for the good experience 😼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat - Prompt for Git
Issue #587 - Creating a project within an existing repository causes a fatal git error
Description
This pull request will prompt the user to choose a version control system.
There's two main reasons for this:
npx create-nuxt-app
in an existing repository fails, as two.git
directories exist. This is especially prevalent in our projects where we have a Django backend and Nuxt frontend in the same repo.This feature has been designed to easily allow another VCS to be added to the list.
Changes
The
prompt.js
asks for a VCS preference in the form of a list.The
saofile.js
will now only rungitInit()
if the respective choice is selected.