Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat: add support for dependabot #604

Merged
merged 7 commits into from
Sep 8, 2020
Merged

feat: add support for dependabot #604

merged 7 commits into from
Sep 8, 2020

Conversation

vinayakkulkarni
Copy link
Contributor

  • When merged, this will enable support for dependabot as one of the devTools options

clarkdo
clarkdo reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're using renovate and also this is kind of outside scope of Nuxt.js, so I'm not sure if it's proper to be merged.

Let's hear feedback from @atinux and @pi0

@clarkdo clarkdo requested review from atinux and pi0 September 8, 2020 09:37
@vinayakkulkarni
Copy link
Contributor Author

As we're using renovate and also this is kind of outside scope of Nuxt.js, so I'm not sure if it's proper to be merged.

Let's hear feedback from @atinux and @pi0

This is basically for a layman user who wants to have dependabot support out-of-the-box (without the need of adding the .github/dependabot.yml file manually afterwards). This PR doesn't affect the create-nuxt-app repo or the nuxt ecosystem in any ways (which uses renovate)

pi0
pi0 suggested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention GH only or switch to renovate

pi0
pi0 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks awesome thanks 💚

clarkdo
clarkdo approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, can you please update README.md as well ?

@vinayakkulkarni
Copy link
Contributor Author

Great, can you please update README.md as well ?

@clarkdo clarkdo merged commit 80e04e9 into nuxt:master Sep 8, 2020
@vinayakkulkarni vinayakkulkarni deleted the feat/add-support-for-dependabot branch September 8, 2020 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkdo clarkdo clarkdo approved these changes

@pi0 pi0 pi0 approved these changes

@atinux atinux Awaiting requested review from atinux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinayakkulkarni @clarkdo @pi0