This repository was archived by the owner on Mar 4, 2025. It is now read-only.
fix(husky): revert stdin tty workaround of #766 for npm #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git Bash workaround for using tty, which is officially recommended by husky in their documentation, is only relevant for yarn, not for npm. Removed isWindows condition make sure projects made by Linux devs are fully accessible to Windows users. Updated husky in a parent project. Added --no-install to npx to avoid accidental installation by default if a project uses different than latest version, but isn't installed.
clarkdo
approved these changes
Jul 15, 2021
clarkdo
approved these changes
Jul 21, 2021
|
To add a link between PRs for future reference, the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isWindowscondition to make sure projects made by Linux devs are fully accessible to Windows users.--no-installto npx to avoid accidental installation by default if a project uses different than latest version, but it isn't installed.